feat(Sqllab): Enabling selection and copying of columns and rows in sql lab and dataset view

[samraHanif0340]

SUMMARY

Problem

• Currently, the users are not able to copy column headers in Sql Lab results section.
• The table columns and rows are not selectable while viewing the datasets metadata before creation.

UseCase

• The copy column name/rows is required to utilise the column names easily while creating the metrics and calculated columns.

Technical Details

• Enable user-select to text in AntTable and VirtualTables in superset-frontend/src/components/Table/index.tsx and superset-frontend/src/components/Table/VirtualTable.tsx

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

SQL LAB

• Go to Sql Lab
• Select any relevant database
• Write and execute and sql query
• In the results section, the query results should appear
• Try selecting column from column header content in the results section

DATASET

• Go to Dataset and create a new dataset
• Select relevant database,schema, table. A dataset metadata view will get generated
• Try selecting the columns or rows from the table view

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues... but I did find this frog.

           .--._.--.
          ( O     O )
          /   . .   \
         .`._______.'.
        /(           )\
      _/  \  \   /  /  \_
   .~   `  \  \ /  /  '   ~.
  {    -.   \  V  /   .-    }
_ _`.    \  |  |  |  /    .'_ _
>_       _} |  |  | {_       _<
 /. - ~ ,_-'  .^.  `-_, ~ - .\
         '-'|/   \|`-`

Files scanned

​

File Path	Reviewed
superset-frontend/src/components/Table/VirtualTable.tsx	✅
superset-frontend/src/components/Table/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[sfirke]

/testenv up

[github-actions]

@sfirke Processing your ephemeral environment request here.

[github-actions]

@sfirke Ephemeral environment spinning up at http://34.219.200.53:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.