Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): fixing helm chart dependency #31614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ochalover
Copy link

@ochalover ochalover commented Dec 25, 2024

Fixing #31613

SUMMARY

  • adding ocr paths for both charts.
  • I am not sure if I should update chart version to the latest as well cause this chart on main branch has CVE issues.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Ran helm dependency build to generate new locks.

Saving 2 charts
Downloading postgresql from repo oci://registry-1.docker.io/bitnamicharts
Pulled: registry-1.docker.io/bitnamicharts/postgresql:12.1.6
Digest: sha256:640c97bc5971fccdd1be6b2c7b399da8858fa83a0cae9ff5ab3dca53a17d1c56
Downloading redis from repo oci://registry-1.docker.io/bitnamicharts
Pulled: registry-1.docker.io/bitnamicharts/redis:17.9.4
Digest: sha256:e20bf7d76f2df0182ff7dd89b19708a80e721450efad891eab314ea892639f78
Deleting outdated charts

ADDITIONAL INFORMATION

  • [X ] Has associated issue:
  • [ X] Required feature flags:
  • [X ] Changes UI
  • [ X] Includes DB Migration (follow approval process in SIP-59)
    • [X ] Migration is atomic, supports rollback & is backwards-compatible
    • [ X] Confirm DB migration upgrade and downgrade tested
    • [X ] Runtime estimates and downtime expectations provided
  • [ X] Introduces new feature or API
  • [X ] Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this penguin.

 __
( o>
///\
\V_/_

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@ochalover ochalover changed the title fix(helm):fixing helm chart dependecy fix(helm):fixing helm chart dependency Dec 25, 2024
@ochalover
Copy link
Author

I am not sure if this is related or not? Is it ok to fix initialbootupscript? It is giving psycog2 error cause new docker image is lacking that.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro changed the title fix(helm):fixing helm chart dependency fix(helm): fixing helm chart dependency Dec 26, 2024
@villebro
Copy link
Member

@ochalover please check #31627. Feel free to make the same changes in this PR to avoid having to wait for my PR to get merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants