Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function signatures to new convention #33

Merged
merged 19 commits into from
Nov 26, 2024

Conversation

stevenclouston
Copy link
Contributor

@stevenclouston stevenclouston commented Nov 25, 2024

Breaking Changes

  1. validate_challenge

    • Old: validate_challenge(user_id: nil, token:, action: nil)
    • New: validate_challenge(token:, user_id: nil, action: nil)
  2. update_user

    • Renamed the user parameter to attributes in the update_user function.
  3. track

    • Updated function signature:
      • Old: def track(event)
      • New: def track(:user_id, :action, :attributes)
  4. enroll_verified_authenticator

    • Updated to accept named parameters: user_id and attributes.
  5. get_user

    • Removed redirectUrl from the function signature.
  6. update_action_state

    • Renamed update_action_state to update_action.
    • Renamed input parameter state to attributes.

Non-Breaking Changes

  1. get_authenticators
    • Added get_authenticators method.

@stevenclouston stevenclouston marked this pull request as ready for review November 26, 2024 01:10
@stevenclouston stevenclouston merged commit 2f59e4e into main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants