Improve push auth err handling (#27)

authsignal · Sep 23, 2024 · a9d204d · a9d204d
1 parent 41af5fc
commit a9d204d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 30 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-authsignal",
-  "version": "1.0.11",
+  "version": "1.0.12",
   "description": "The official Authsignal React Native library.",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

diff --git a/src/push.ts b/src/push.ts
@@ -1,5 +1,5 @@
 import { NativeModules } from 'react-native';
-import { LINKING_ERROR } from './error';
+import { handleErrorCodes, LINKING_ERROR } from './error';
 import type {
   AuthsignalResponse,
   PushChallenge,
@@ -58,17 +58,13 @@ export class AuthsignalPush {
         console.log(ex);
       }
 
-      if (ex instanceof Error) {
-        return { error: ex.message };
-      }
-
-      throw ex;
+      return handleErrorCodes(ex);
     }
   }
 
-  async addCredential({
-    token,
-  }: AddCredentialInput): Promise<AuthsignalResponse<boolean>> {
+  async addCredential({ token }: AddCredentialInput = {}): Promise<
+    AuthsignalResponse<boolean>
+  > {
     await this.ensureModuleIsInitialized();
 
     try {
@@ -80,11 +76,7 @@ export class AuthsignalPush {
         console.log(ex);
       }
 
-      if (ex instanceof Error) {
-        return { error: ex.message };
-      }
-
-      throw ex;
+      return handleErrorCodes(ex);
     }
   }
 
@@ -99,11 +91,7 @@ export class AuthsignalPush {
         console.log(ex);
       }
 
-      if (ex instanceof Error) {
-        return { error: ex.message };
-      }
-
-      throw ex;
+      return handleErrorCodes(ex);
     }
   }
 
@@ -119,11 +107,7 @@ export class AuthsignalPush {
         console.log(ex);
       }
 
-      if (ex instanceof Error) {
-        return { error: ex.message };
-      }
-
-      throw ex;
+      return handleErrorCodes(ex);
     }
   }
 
@@ -147,11 +131,7 @@ export class AuthsignalPush {
         console.log(ex);
       }
 
-      if (ex instanceof Error) {
-        return { error: ex.message };
-      }
-
-      throw ex;
+      return handleErrorCodes(ex);
     }
   }