feat(ecs): enable Enhanced Observability for Container Insights #32622
Conversation
github-actions
bot
added
effort/small
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
MPOgbourne
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…insights' into feat-aws-ecs-enhanced-container-insights
aws-cdk-automation
added
the
pr/needs-community-review
| /** | ||
| * The CloudWatch Container Insights configuration for the cluster | ||
| * | ||
| * @default - Container Insights configuration will not be set for the cluster |
There was a problem hiding this comment.
A bit ambiguous, that does not indicate the actual default value. I'm assuming the insights would be disabled?
There was a problem hiding this comment.
The default is not entirely straightforward. If no setting is specified, no setting for container insights is set on the cluster, and the container insights setting is inherited from any account level ecs settings. Most likely, container insights would be disabled, but that isn't guaranteed. I updated the default message to " Container Insights will be disabled for this cluster, but this may be overridden by ECS account level settings." If we'd prefer to just just say it's disabled, I'm fine with that as well.
...s-cdk-testing/framework-integ/test/aws-ecs/test/integ.cluster-enhanced-container-insights.ts
Show resolved
Hide resolved
…insights' into feat-aws-ecs-enhanced-container-insights
…insights' into feat-aws-ecs-enhanced-container-insights
aws-cdk-automation
removed
the
pr/needs-community-review
…insights' into feat-aws-ecs-enhanced-container-insights
aws-cdk-automation
added
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32618.
Reason for this change
Container Insights with enhanced observability was recently announced and released for ECS. Cloudformation and the L1 CFN construct support setting this at cluster level. This adds the Container Insights with enhanced observability as an option for the existing L2 Cluster construct.
Description of changes
ENHANCED was added to the ContainerInsights enum. A new containerInsightsV2 property was added to the Cluster construct with the type ContainerInsights. The existing containerInsights property was marked as deprecated.
Description of how you validated changes
Unit and Integration tests were added.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license