chore: add aws-cdk-lib/core to codecov
#32641
Conversation
| run: cd packages/aws-cdk && yarn test | ||
|
|
||
| - name: Upload results to Codecov | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| directory: packages/aws-cdk/coverage | ||
| files: packages/aws-cdk/coverage/cobertura-coverage.xml,packages/aws-cdk-lib/coverage/cobertura-coverage.xml |
There was a problem hiding this comment.
I prefer pointing to the expected files because I don't trust codecov's search heuristic.
Note that this won't need another change if we decide to add another submodule (or the entire lib).
| @@ -8,6 +8,8 @@ module.exports = { | |||
| testMatch: [ | |||
| '<rootDir>/**/test/**/?(*.)+(test).ts', | |||
| ], | |||
| coveragePathIgnorePatterns: ['\\.generated\\.[jt]s$', '<rootDir>/.*/test/', '.warnings.jsii.js$', '/node_modules/'], | |||
There was a problem hiding this comment.
This is an override of the base config with a small adjustment to ignoring test files. We need this to ignore files inside aws-cdk-lib/core/test
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32641 +/- ##
===========================================
- Coverage 80.69% 66.94% -13.75%
===========================================
Files 108 329 +221
Lines 7019 18651 +11632
Branches 1299 3256 +1957
===========================================
+ Hits 5664 12486 +6822
- Misses 1175 5838 +4663
- Partials 180 327 +147
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Fun stuff, adding |
|
Comments on closed issues and PRs are hard for our team to see. |
Example report