feat(elasticloadbalancingv2): support AdvertiseTrustStoreCaNames for mTLS #32678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
valued-contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32678 +/- ##
==========================================
+ Coverage 80.52% 80.69% +0.16%
==========================================
Files 106 108 +2
Lines 6948 7019 +71
Branches 1287 1299 +12
==========================================
+ Hits 5595 5664 +69
Misses 1175 1175
- Partials 178 180 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
suggested changes
Dec 28, 2024
| * | ||
| * @default AdvertiseTrustStoreCaNames.OFF | ||
| */ | ||
| readonly advertiseTrustStoreCaNames?: AdvertiseTrustStoreCaNames; |
There was a problem hiding this comment.
What about changing the type to a boolean and removing the enum? It would provide a cleaner interface
There was a problem hiding this comment.
Thanks 👍 You can find a sample for the suggested approach here
There was a problem hiding this comment.
Thank you for the nice sample! I made an update according to it.
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
AWS Application Load Balancer introduces Certificate Authority advertisement to simplify client behavior while using Mutual TLS
Ref: MutualAuthenticationAttributes
Description of changes
Added advertiseTrustStoreCaNames property for MutualAuthentication.
Description of how you validated changes
Updated
alb/listener.test.tsandinteg.alb-mtls.ts.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license