Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: correctly read environment variable from CodeBuild configuration for scheduled fuzz test #4990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jouho
Copy link
Contributor

@jouho jouho commented Dec 26, 2024

Release Summary:

Resolved issues:

Currently scheduled fuzz test only runs for 60 seconds, even though we set FUZZ_TIMEOUT_SEC environment variable to a longer duration on CodeBuild project configuration. This PR fixes it by correctly reading the value from system environment.

Description of changes:

Updated to use ENV keyword for reading timeout values from CodeBuild's system environment variables, replacing the previous approach of passing timeout via -D argument, which was removed in PR #4960.

Call-outs:

Testing:

Overridden scheduled fuzz test with 300 seconds timeout. Default is 60 seconds: Link to CodeBuild job

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Dec 26, 2024
add missing $ sign

set timeout env if defined

fix syntax

edit comment
@jouho jouho requested review from dougch and boquan-fang December 26, 2024 22:14
@jouho jouho marked this pull request as ready for review December 26, 2024 22:14
@jouho jouho changed the title ci: correctly read environment variable from codebuild ci: correctly read environment variable from CodeBuild configuration for scheduled fuzz test Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant