Toolbar Button: Handle click instead of mousedown
#1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert [c4b9d5b][] Requiring mouse events to trigger `<button>` element event listeners poses accessibility issues for keyboard users. The context in the original commit ([c4b9d5b][]) is fairly light, and there doesn't appear to be a link to a GitHub pull request with more information. The provided context is: > Prevents flickering of the placeholder text when clicking block > formatting buttons on an empty document. Since the commit is from 2014, there is hope that the underlying flicker might have been resolved through the natural course of browser improvements and device enhancements. The benefit of responding to keyboard events when the `<button>` element has focus outweighs the potential downsides. [c4b9d5b]: basecamp@c4b9d5b
|
@brunoprietog are you available to review this change? I think there's a potential to resolve a long-term accessibility issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert c4b9d5b
Requiring mouse events to trigger
<button>element event listeners poses accessibility issues for keyboard users.The context in the original commit (c4b9d5b) is fairly light, and there doesn't appear to be a link to a GitHub pull request with more information. The provided context is:
Since the commit is from 2014, there is hope that the underlying flicker might have been resolved through the natural course of browser improvements and device enhancements.
The benefit of responding to keyboard events when the
<button>element has focus outweighs the potential downsides.