Provide correct context to issueAjaxRequest #2770
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #2147
Description
Instead of passing the element that the request was triggered on,
ajax
is passingnull
which causesissueAjaxRequest
to default to the BODY element. When multiple requests are queued at once,htmx
thinks they're all associated with BODY and so it ignores or limits the subsequent simultaneous requests.Corresponding issue: #2147
Testing
I've used this change in my own project. Also ran
htmx
's own tests.Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded