Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier to normalize code style #81

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

botandrose
Copy link

Okay, @1cg , here's the first sample of what a PR for this might look like. I'm betting you'll have some opinions about this!

Questions:

  1. Prettier defaults to 2-space tabs, rather than your 4 spaces. Do you want this to be changed to 4 in the prettier config?
  2. Any other config settings you wanna tweak?
  3. Turns out it can tidy up Markdown. That seems... nice? Or should we not bother and add *.md it to .prettierignore
  4. How should we enforce this, moving forward? It'd be trivial to add a job to the CI to fail the build if prettier wasn't ran, for example. But then we'd need to communicate to PR authors to be sure to run npm run format before committing. That's some minor added friction.

@botandrose botandrose changed the title [DRAFT] Add prettier to normalize code style Add prettier to normalize code style Dec 23, 2024
@botandrose
Copy link
Author

@1cg Okay, good to go. We discussed in Discord, but for posterity:
1 & 2. Sticking with defaults
3. No markdown, presentation is more important than consistency in docs
4. Not a lot of churn in this repo normally, so will be run manually before release

@1cg 1cg merged commit 2bc3a84 into bigskysoftware:main Dec 23, 2024
4 checks passed
@botandrose botandrose deleted the prettier branch December 28, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants