Use XDomainRequest in browsers which can't CORS with XMLHttpRequest #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: index.js
…, use XDomainRequest if it exists
| @@ -26,8 +26,7 @@ http.request = function (params, cb) { | |||
| params.host = params.host.split(':')[0]; | |||
| } | |||
| if (!params.port) params.port = params.scheme == 'https' ? 443 : 80; | |||
|
|
|||
| var req = new Request(new xhrHttp, params); | |||
| var req = new Request(new (xhrHttp(params)), params); | |||
There was a problem hiding this comment.
an appropriate XHR-like thing is now chosen based on the params, not just once at eval time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 has been open and unresponded to for three years. I +1d it, but went to use that fork and realized it didn't really even work.
This pull request is up to date with 1.4.1, and I've tested it a good amount in IE9 while working on https://github.com/gobengo/chronos-stream, and more important will continue to maintain it for my job @Livefyre in the forseeable future.
@substack, now with some legwork into this, will you please respond and say whether you find this change in scope appropriate for http-browserify and the OOB 'http' builtin?
If you never want it in the builtin, we can close this PR and folks can just use http-browserify-xdr manually if they want. But at least this issue will be here for posterity.
If you are supportive, I'll get the README changes out of this PR that I made.