This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
interceptor/opencensus: record number of received spans #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
force-pushed
the
stats-instrument-opencensus-interceptor
branch
2 times, most recently
from
f299e24 to
8993460
Compare
bogdandrutu
reviewed
Oct 5, 2018
interceptor/opencensus/opencensus.go
Outdated
|
|
||
| // We MUST Unconditionally record metrics from this reception. |
There was a problem hiding this comment.
Thanks, I'll update that.
interceptor/opencensus/opencensus.go
Outdated
| @@ -88,20 +90,28 @@ func (oci *OCInterceptor) Export(tes agenttracepb.TraceService_ExportServer) err | |||
| return errTraceExportProtocolViolation | |||
| } | |||
|
|
|||
| var lastNonNilNode *commonpb.Node | |||
| spansMetricsFn := internal.NewReceivedSpansRecorder(context.Background(), "opencensus") | |||
There was a problem hiding this comment.
Use tags from the current context (they include tags emitted by the oc-library-agent-exporter)?
There was a problem hiding this comment.
Great reminder, that'd entail changing that to tes.Context(), thanks.
|
Probably forgot to push the commit. I cannot see any update. |
odeke-em
force-pushed
the
stats-instrument-opencensus-interceptor
branch
from
f6cb1b9 to
2dc4ade
Compare
@bogdandrutu in deed, PTAL! |
odeke-em
force-pushed
the
stats-instrument-opencensus-interceptor
branch
from
2dc4ade to
393b819
Compare
bogdandrutu
reviewed
Oct 7, 2018
odeke-em
force-pushed
the
stats-instrument-opencensus-interceptor
branch
from
81c1aaf to
e4c1aa3
Compare
bogdandrutu
approved these changes
Oct 7, 2018
|
Thank you for the review @bogdandrutu! |
Instrument interceptor/opencensus with stats to record the number of received spans. This is accomplished by a helper to process spans that sends over spans even if the number of spans is 0. Also record with tag_key "opencensus_interceptor" whose value is the name of the respective interceptor. The test to ensure that 0 length spans are also added is currently disabled because: * Issue census-instrumentation/opencensus-go#862 is not yet implemented which requests that the OpenCensus-Go stats worker provide a method Flush to flush all data. Without it, metrics will contain stale data from previous tests. Add tests to lock-in this behavior. Also replace grpc.NewServer with a stats enabled server helper call. This enables tracing and metrics for each gRPC server by replacing naked usages of grpc.NewServer with the new helper function: internal.GRPCServerWithObservabilityEnabled Updates #63
odeke-em
force-pushed
the
stats-instrument-opencensus-interceptor
branch
from
e4c1aa3 to
bdb4d3d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrument interceptor/opencensus with stats to record
the number of received spans. This is accomplished by
a helper to process spans that sends over spans even
if the number of spans is 0. Also record with tag_key
"opencensus_interceptor" whose value is the name
of the respective interceptor.
The test to ensure that 0 length spans are also added
is currently disabled because:
is not yet implemented which requests that the OpenCensus-Go
stats worker provide a method Flush to flush all data. Without
it, metrics will contain stale data from previous tests.
Add tests to lock-in this behavior.
Updates #63