Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to create our own WPT archive #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

npaun
Copy link
Member

@npaun npaun commented Dec 20, 2024

We use Web Platform Tests to test workerd. Currently, we depend on the Github-provided tarballs for the WPT release we use. However, these downloads don't seem to be stable, with the hash changing from time to time. This is a nuisance for anyone trying to roll deps.

In this PR, I've added a small action to download WPT, pack it into an archive and upload it as a fixed asset to a Github release. This way we know the generation of the archive is entirely under our control. This should put a stop to this nuisance.

@npaun npaun requested review from fhanau and danlapid December 20, 2024 23:24
@npaun npaun requested a review from a team as a code owner December 20, 2024 23:24
Copy link
Collaborator

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the license of WPT? Are we allowed to redistribute it?

@npaun
Copy link
Member Author

npaun commented Dec 21, 2024

I checked when we started the WPT project -- It's BSD (https://github.com/web-platform-tests/wpt/blob/master/LICENSE.md)

@danlapid
Copy link
Collaborator

Ok so what's our plan on keeping this up to date with new wpt releases?

@fhanau
Copy link

fhanau commented Dec 22, 2024

Looks reasonable to me (I assume this was tested in some capacity)
Re. Dan's comment, wpt tests don't change at a rapid pace so re-generating this every few months should be sufficient coverage. Since it is a workflow dispatch action, doing so is easy.

@fhanau
Copy link

fhanau commented Dec 22, 2024

Semi-related, and absolutely non-blocking: Based on profiling, using wpt is one of the reasons why starting up Bazel is slow, especially on Windows where the analysis phase takes > 5 minutes. I'm not sure why this is the case (too many files for Bazel to index? Bazel being slow at decompressing or writing the data to disk?) but it is affecting CI performance. We could experiment with having an archive that only includes the folders for which we run tests, and see if that helps.

@danlapid
Copy link
Collaborator

Semi-related, and absolutely non-blocking: Based on profiling, using wpt is one of the reasons why starting up Bazel is slow, especially on Windows where the analysis phase takes > 5 minutes. I'm not sure why this is the case (too many files for Bazel to index? Bazel being slow at decompressing or writing the data to disk?) but it is affecting CI performance. We could experiment with having an archive that only includes the files we use, and see if that helps.

We could also consider only testing wpt on Linux, is there really much to gain from testing wpt on every platform separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants