-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: Change release
to released
#104
Conversation
Close this duplicate. |
I can't understand you |
I was not able to get the commit message errors. So, I read the commit guidelines and then I made the rest pull requests. But they also failed. |
I closed all the other duplicate PR's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't close this PR, 3 others have already been closed.
Also, squash the commits and follow the commit guidelines for the final commit.
I read the commit guidelines but I am getting errors. I might be doing something wrong. Can you please help me with what is wrong in the heading of the PR. |
But you aren't following the commit guidelines. Squash the commits and change the message. Meanwhile, I'll check what the errors are. |
The netlify errors are not because of your change. Don't worry about them. Just do this -
|
Will do |
Ping. Please fix. |
Don't worry, I will fix this issue by this Sunday.
…On Jan 31, 2019 12:20, "John Vandenberg" ***@***.***> wrote:
Ping. Please fix.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#104 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcUIb_tHkRs90SrrzP2HjUyDrZfNzv3hks5vIpIbgaJpZM4aGmvM>
.
|
Fixes #76
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use corobo mark wip to get it out
of the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!