-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Script: Firefly #616
base: main
Are you sure you want to change the base?
New Script: Firefly #616
Conversation
I have no experience with LAMP stacks etc neither composer. |
ct/firefly.sh
Outdated
rm -rf /opt/firefly | ||
cd /opt | ||
wget -q "https://github.com/firefly-iii/firefly-iii/releases/download/v${RELEASE}/FireflyIII-v${RELEASE}.tar.gz" | ||
mkdir -p /opt/firefly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? ^^ Clean above rm -rf /opt/firefly/* then is Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're totally correct! Fixed it 😁
ct/firefly.sh
Outdated
chown -R www-data:www-data /opt/firefly | ||
chmod -R 775 /opt/firefly/storage | ||
|
||
echo "${RELEASE}" >"/opt/${APP}_version.txt" &>/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev/null not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
ct/firefly.sh
Outdated
mkdir -p /opt/firefly | ||
tar -xzf FireflyIII-v${RELEASE}.tar.gz -C /opt/firefly --exclude='storage' | ||
cd /opt/firefly | ||
composer install --no-dev &>/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composer is a sucker. add --no-interaction too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
curl \ | ||
mc \ | ||
sudo | ||
curl -sSLo /usr/share/keyrings/deb.sury.org-php.gpg https://packages.sury.org/php/apt.gpg | ||
echo "deb [signed-by=/usr/share/keyrings/deb.sury.org-php.gpg] https://packages.sury.org/php/ bookworm main" >/etc/apt/sources.list.d/php.list | ||
$STD apt-get update | ||
$STD apt-get install -y \ | ||
apache2 \ | ||
php8.3 \ | ||
php8.3-cli \ | ||
libapache2-mod-php8.3 \ | ||
php8.3-{bcmath,intl,curl,zip,gd,xml,mbstring,mysql} \ | ||
mariadb-server \ | ||
composer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split into Default dependencies (Apache2, madiadb above)
And then create a new MSG Section "Setup PHP" with only the PHP stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I do not understand how to split this. Do you have any example CTs I can refer to?
ct/firefly.sh
Outdated
#!/usr/bin/env bash | ||
source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func) | ||
# Copyright (c) 2021-2024 community-scripts ORG | ||
# Author: kristocopani | ||
# License: MIT | ||
# https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE | ||
|
||
function header_info { | ||
clear | ||
cat <<"EOF" | ||
_______ ______ ____________ | ||
/ ____(_)_______ / __/ /_ __ / _/ _/ _/ | ||
/ /_ / / ___/ _ \/ /_/ / / / / / / / / / / | ||
/ __/ / / / / __/ __/ / /_/ / _/ /_/ /_/ / | ||
/_/ /_/_/ \___/_/ /_/\__, / /___/___/___/ | ||
/____/ | ||
|
||
EOF | ||
} | ||
header_info | ||
echo -e "Loading..." | ||
APP="Firefly" | ||
var_disk="2" | ||
var_cpu="1" | ||
var_ram="1024" | ||
var_os="debian" | ||
var_version="12" | ||
variables | ||
color | ||
catch_errors | ||
|
||
function default_settings() { | ||
CT_TYPE="1" | ||
PW="" | ||
CT_ID=$NEXTID | ||
HN=$NSAPP | ||
DISK_SIZE="$var_disk" | ||
CORE_COUNT="$var_cpu" | ||
RAM_SIZE="$var_ram" | ||
BRG="vmbr0" | ||
NET="dhcp" | ||
GATE="" | ||
APT_CACHER="" | ||
APT_CACHER_IP="" | ||
DISABLEIP6="no" | ||
MTU="" | ||
SD="" | ||
NS="" | ||
MAC="" | ||
VLAN="" | ||
SSH="no" | ||
VERB="no" | ||
echo_default | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you migrate to new header? Example:
#!/usr/bin/env bash
source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
# Copyright (c) 2021-2024 tteck
# Author: MickLesk (Canbiz) & vhsdream
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
# Source: https://hoarder.app/
# App Default Values
APP="Hoarder"
var_tags="bookmark"
var_cpu="2"
var_ram="4096"
var_disk="8"
var_os="debian"
var_version="12"
var_unprivileged="1"
# App Output & Base Settings
header_info "$APP"
base_settings
# Core
variables
color
catch_errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
ct/firefly.sh
Outdated
msg_ok "Completed Successfully!\n" | ||
echo -e "${APP} should be reachable by going to the following URL. | ||
${BL}http://${IP}${CL} \n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you migrate to new footer? Example:
msg_ok "Completed Successfully!\n"
echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
echo -e "${INFO}${YW} Access it using the following URL:${CL}"
echo -e "${TAB}${GATEWAY}${BGN}http://${IP}:3000${CL}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Hey! I was out of town last week and work is going crazy. |
Could this also include firefly-iii-fints-importer? Or the Data Importer? |
Can you perhaps add a query that allows you to integrate an external database into an existing LXC? |
@quantumryuu What is the status of your PRs? They have been open for 4 weeks now. |
Note
We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.
Description
Created install script for Firefly
Fixes # (issue)
#385
Project Board
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
Provide any additional context or screenshots about the feature or fix here.
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here: