Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tobias-Fischer to pytorch windows policy #25

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

Tobias-Fischer
Copy link
Contributor

To work on conda-forge/pytorch-cpu-feedstock#302

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@Tobias-Fischer
Copy link
Contributor Author

@isuruf @h-vetinari @wolfv - could you please take a look :)

@h-vetinari
Copy link
Member

My understanding is that the bot should open this PR (I looked for it yesterday already...)? CC @jaimergp

Otherwise LGTM

@Tobias-Fischer
Copy link
Contributor Author

Ah - I understand now. Let me put a proper fix.

@Tobias-Fischer Tobias-Fischer changed the title Add Tobias-Fischer to .access.yml Change pytorch windows policy to use Quansight list Dec 13, 2024
@Tobias-Fischer
Copy link
Contributor Author

Maybe I don't fully understand just yet - there are two separate policies for pytorch feedstock, one "generic" (which so far uses the Quansight list) and one "Windows" policy (which thus far only had @baszalmstra and @wolfv listed). I changed the Windows policy to also use the Quansight list.

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two servers are managed by two different orgs (Quansight and prefix.dev).
There shouldn't be any mixing of the two.

@Tobias-Fischer Tobias-Fischer changed the title Change pytorch windows policy to use Quansight list Add Tobias-Fischer to pytorch windows policy Dec 13, 2024
@Tobias-Fischer
Copy link
Contributor Author

Thanks for the clarification @isuruf!

/cc @wolfv @baszalmstra @jaimergp - not sure what the proper way is for adding a non-prefix.dev person to the list; should I accept some T&Cs somewhere?

@wolfv
Copy link
Member

wolfv commented Dec 13, 2024

More than happy to let you use this resource! I am going to wait for @jaimergp to merge this as I am not sure if there needs to be any bot involvement.

@jaimergp
Copy link
Member

Yea I think the Cirun app should have opened this, but I'm not sure if that only happens for the GPU server. I'll merge but I'll also ping @aktech in case some clarification can be given.

@jaimergp jaimergp merged commit 9b06dfb into conda-forge:master Dec 13, 2024
@aktech
Copy link
Contributor

aktech commented Dec 17, 2024

@cirun-bot only creates PR when these requests happen from admin-requests repo.

Also, I don't think admin-requests or conda-smithy accepts users param for feedstock yet, so as to pass to cirun client, which does supports adding user to policy to create a PR to update .access.yml.

conda smithy cli
$ conda-smithy register-ci --help
usage: conda smithy register-ci [-h] [--feedstock_directory FEEDSTOCK_DIRECTORY] [--feedstock_config FEEDSTOCK_CONFIG] [--user USER | --organization ORGANIZATION] [--without-azure] [--with-azure] [--without-travis] [--with-travis] [--without-circle] [--with-circle]
                                [--without-appveyor] [--with-appveyor] [--without-drone] [--with-drone] [--without-webservice] [--with-webservice] [--without-cirun] [--with-cirun] [--without-all] [--without-anaconda-token] [--drone-endpoints DRONE_ENDPOINTS]
                                [--cirun-teams CIRUN_TEAMS] [--cirun-roles CIRUN_ROLES] [--cirun-users-from-json CIRUN_USERS_FROM_JSON] [--cirun-resources CIRUN_RESOURCES] [--cirun-policy-args CIRUN_POLICY_ARGS] [--remove]

Register a feedstock at the CI services which do the builds.

options:
  -h, --help            show this help message and exit
  --feedstock_directory FEEDSTOCK_DIRECTORY
                        The directory of the feedstock git repository.
  --feedstock_config FEEDSTOCK_CONFIG
                        The feedstock configuration file. By default, {FEEDSTOCK_DIRECTORY}/conda-forge.yml
  --user USER           github username under which to register this repo
  --organization ORGANIZATION
                        github organisation under which to register this repo
  --without-azure       If set, Azure will be not registered
  --with-azure          If set, Azure will be registered
  --without-travis      If set, Travis will be not registered
  --with-travis         If set, Travis will be registered
  --without-circle      If set, Circle will be not registered
  --with-circle         If set, Circle will be registered
  --without-appveyor    If set, Appveyor will be not registered
  --with-appveyor       If set, Appveyor will be registered
  --without-drone       If set, Drone will be not registered
  --with-drone          If set, Drone will be registered
  --without-webservice  If set, Webservice will be not registered
  --with-webservice     If set, Webservice will be registered
  --without-cirun       If set, Cirun will be not registered
  --with-cirun          If set, Cirun will be registered
  --without-all         If set, none of the CI providers are registered and need to be enabled individually.
  --without-anaconda-token
                        If set, no anaconda token will be registered with the CI providers.
  --drone-endpoints DRONE_ENDPOINTS
                        drone server URL to register this repo. multiple values allowed
  --cirun-teams CIRUN_TEAMS
                        github teams to enable in cirun for this repo. multiple values allowed
  --cirun-roles CIRUN_ROLES
                        github roles to enable in cirun for this repo. multiple values allowed
  --cirun-users-from-json CIRUN_USERS_FROM_JSON
                        A remote URL with a list of users to enable in cirun for this repo.
  --cirun-resources CIRUN_RESOURCES
                        cirun resources to enable for this repo. multiple values allowed
  --cirun-policy-args CIRUN_POLICY_ARGS
                        extra arguments for cirun policy to create for this repo. multiple values allowed
  --remove              Revoke access to the configured CI services. Only available for Cirun for now

@jaimergp Should we update admin-requests and conda-smithy to support this?

@jaimergp
Copy link
Member

@aktech, yep at the very least we should open an issue there to track this! Thanks!

@aktech
Copy link
Contributor

aktech commented Dec 18, 2024

Created one in conda-smithy: conda-forge/conda-smithy#2194 will create one for admin-requests to use that in there.

Update: created one in admin-requests: conda-forge/admin-requests#1237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants