Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with wrong terminal size during tab switch #1682

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

Yaraslaut
Copy link
Member

Fix crash with resize and tab switching, we notice this bug on systems with scaled UI (specifically macOS, but bug can appear on other systems as well)

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Dec 28, 2024
@Yaraslaut Yaraslaut force-pushed the fix/resize_and_tab_switch branch from 265965d to 2f3e78a Compare December 28, 2024 22:09
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you to have a look on my second commit on top to, but I'd think it now looks all "okay" (bug is fixed) :)

@Yaraslaut
Copy link
Member Author

I would like you to have a look on my second commit on top to, but I'd think it now looks all "okay" (bug is fixed) :)

looks good for me :)

@christianparpart christianparpart force-pushed the fix/resize_and_tab_switch branch from 16180c0 to 83b033b Compare December 28, 2024 23:01
…ay size including its configured visual margin

Signed-off-by: Christian Parpart <[email protected]>
@christianparpart christianparpart force-pushed the fix/resize_and_tab_switch branch from 83b033b to b79b31c Compare December 28, 2024 23:05
@Yaraslaut Yaraslaut enabled auto-merge December 28, 2024 23:16
@Yaraslaut Yaraslaut merged commit cf129d8 into master Dec 28, 2024
30 checks passed
@Yaraslaut Yaraslaut deleted the fix/resize_and_tab_switch branch December 28, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants