This repository has been archived by the owner on Jun 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Latest version #49
Open
christophe-g
wants to merge
7
commits into
crossfilter:master
Choose a base branch
from
PolymerEl:latestVersion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Latest version #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophe-g
commented
Nov 29, 2017
- Updated universe to latest crossfilter and reductio
- remove data with predicate as per https://github.com/crossfilter/crossfilter/wiki/API-Reference#wiki-crossfilter_remove
- make sure active filters are reapplied weh add/remove data
- add build version to the package
Hey @tannerlinsley - any chance this get reviewed ? The ability to remove data with predicate is very useful when you want to deal dynamically with data update. In this case, you need a way to tell |
.gitignore
Outdated
@@ -2,7 +2,5 @@ node_modules/ | |||
npm-debug.log | |||
.coverrun | |||
coverage/coverage.html | |||
/universe.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't want to commit these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @tannerlinsley,
reverted .gitignore to original.
Updated crossfilter to latest release (1.4.6)
christophe-g
force-pushed
the
latestVersion
branch
from
October 18, 2018 08:07
ccd08e7
to
05da6e2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.