Make danger work with pull_request_target in GH Actions #1501
+12
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fetch base and head for a GitHub pull request make sure to do so from the correct remote instead of assuming that they are both present in the origin remote.
To explain more, when we are running as
pull_request_target
the checked out repository is the target repository and while it contains the proposed change it is asrefs/pull/N/head
and not asrefs/heads/BRANCH
so trying to fetch using the branch name will not work.This change ensures that we fetch both base and head from the remote that matches the ref as given in the pull request data returned from the API.
I haven't checked but I think the opposite problem may be possible for
pull_request
if the source and target somehow had base branches that diverged as it will have the source repository asorigin
but will be looking for a target repository reference. That is probably a lot less likely but this ensures that we fetch both from the correct place anyway.This should fix #1103.