Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

SnapshotReader - Completed #48

Merged
merged 7 commits into from
Apr 4, 2024
Merged

SnapshotReader - Completed #48

merged 7 commits into from
Apr 4, 2024

Conversation

Trickybrain
Copy link
Collaborator

No description provided.

@Trickybrain Trickybrain changed the title SnapshotReader - Edwin - Not completed SnapshotReader - Completed Mar 29, 2024
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great except it needs type hints.

@@ -0,0 +1,20 @@
class ConvertToWindowsNewlines:
def __init__(self, sink):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs types. What is sink?

Comment on lines +6 to +8
def __init__(self, subject, facet_data):
self._subject = subject
self._facet_data = facet_data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs types.

def __hash__(self):
return hash((self._subject, frozenset(self._facet_data.items())))

def plus_facet(self, key, value):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types

@nedtwigg nedtwigg marked this pull request as ready for review April 4, 2024 18:09
@nedtwigg nedtwigg merged commit eb3e99c into diffplug:main Apr 4, 2024
2 checks passed
@nedtwigg nedtwigg mentioned this pull request Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants