-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update docker/docker master, and remove uses of github.com/moby/sys/user #5708
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5708 +/- ##
=======================================
Coverage 59.52% 59.52%
=======================================
Files 346 346
Lines 29381 29381
=======================================
Hits 17488 17488
Misses 10923 10923
Partials 970 970 |
a5ec623
to
cf6bebd
Compare
cf6bebd
to
ee8ad8a
Compare
After this, pkg/pools is still in use in the CLI for the Classic Builder; cli/cli/command/image/build/context.go Lines 426 to 447 in 3b49deb
That was;
However, on that PR, it was suggested to move the |
Failures look legit / related;
|
65cd67f
to
62d136c
Compare
Rebased after #5715 was merged, which should fix the faulty test. |
full diff: moby/moby@a72026a...f5af46d Signed-off-by: Sebastiaan van Stijn <[email protected]>
removes dependency on github.com/moby/sys/user Signed-off-by: Sebastiaan van Stijn <[email protected]>
62d136c
to
c113896
Compare
pkg/pools
in archive moby/moby#49117testing changes from Split idtools to an internal package and package to be moved moby/moby#49087- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)