Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor email confirmation handling to delegate to the client #59648

Closed

Conversation

girgisadel
Copy link

@girgisadel girgisadel commented Dec 28, 2024

Refactor email confirmation logic to delegate to the client side

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

This PR introduces a new ClientOptions class to encapsulate client-specific configuration for email confirmation URLs, and updates the IdentityOptions and IdentityApiEndpointRouteBuilderExtensions classes to support these configurations.

changes allow greater flexibility in customizing the email confirmation URL, moving the responsibility to the client-side rather than the back-end.

Fixes #59647

@girgisadel girgisadel requested a review from a team as a code owner December 28, 2024 03:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-identity Includes: Identity and providers label Dec 28, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 28, 2024
@girgisadel
Copy link
Author

@dotnet-policy-service agree

@girgisadel girgisadel closed this by deleting the head repository Dec 28, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Move email confirmation handling to the client
1 participant