[dsrouter] fix web socket startup #5121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @lateralusX |
lateralusX
reviewed
Dec 19, 2024
| @@ -211,7 +211,7 @@ private static Option WebSocketURLAddressOption() => | |||
| description: "The router WebSocket address using format ws://[host]:[port]/[path] or wss://[host]:[port]/[path]. " + | |||
| "Launch app with WasmExtraConfig property specifying diagnostic_options with a server connect_url") | |||
| { | |||
| Argument = new Argument<string>(name: "webSocketURI", getDefaultValue: () => "") | |||
| Argument = new Argument<string>(name: "webSocketURI", getDefaultValue: () => "ws://127.0.0.1:8088/diagnostics") | |||
There was a problem hiding this comment.
This seems to already be set as the default value as part of WeSocketServerRouterFactory,
There was a problem hiding this comment.
Yes, but it also needs to flow into WebSocketServerImpl.ParseWebSocketURL otherwise it throws on empty value and continues starting silently without actually working!
There was a problem hiding this comment.
ok, let me check that, sound like that parsing should be done elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ws://127.0.0.1:8088/diagnosticsws://orwss://as it only acceptshttp://orhttps://schema