WIP on ConvertingValueComparer #35354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2024
| return valueComparer; | ||
| } | ||
|
|
||
| if (targetClrType.IsNullableValueType() && !valueComparer.Type.IsNullableValueType()) |
There was a problem hiding this comment.
Don't you also need to check that targetClrType.UnwrapNullableType() == valueComparer.Type?
|
I still believe that for 9.0.2 #35360 is a less risky fix and considering that we need to keep the legacy code for quirk, I don't see any downside to it. |
|
OK @AndriySvyryd, am OK with that. @maumar @AndriySvyryd you can close this PR or keep it, reusing the code here for the 10 fix if we end up going that way. |
|
Superceeded by #35326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for #35326 (comment)