System.Reflection.CustomAttributeFormatException thrown on a retrieval of derived attribute with overridden property getter #110945
Conversation
…l of derived attribute with overridden property getter
dotnet-policy-service
bot
added
the
community-contribution
| @@ -1580,7 +1580,7 @@ private static void AddCustomAttributes( | |||
| RuntimeMethodInfo setMethod = property.GetSetMethod(true)!; | |||
|
|
|||
| // Public properties may have non-public setter methods | |||
| if (!setMethod.IsPublic) | |||
| if (setMethod == null || !setMethod.IsPublic) | |||
There was a problem hiding this comment.
is null to avoid unnecessary comparison operator
| @@ -1580,7 +1580,7 @@ private static void AddCustomAttributes( | |||
| RuntimeMethodInfo setMethod = property.GetSetMethod(true)!; | |||
There was a problem hiding this comment.
The nullability suppression should also be removed
src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderSetCustomAttribute.cs
Outdated
Show resolved
Hide resolved
| Type? baseDeclaredType = declaredType.BaseType; | ||
|
|
||
| while ((m_getterMethod == null || m_setterMethod == null) | ||
| && baseDeclaredType != null && baseDeclaredType is RuntimeType baseDeclaredRuntimeType) |
There was a problem hiding this comment.
| && baseDeclaredType != null && baseDeclaredType is RuntimeType baseDeclaredRuntimeType) | |
| && baseDeclaredType is RuntimeType baseDeclaredRuntimeType) |
The pattern match also does a null check.
| out _, out _, out _, | ||
| out m_getterMethod, out m_setterMethod, out m_otherMethod, | ||
| out isPrivate, out m_bindingFlags); | ||
|
|
||
| // lookup getter/setter when getter and setter are inherited from base class but just a setter/getter is overridden on a sub type | ||
| if ((m_getterMethod != null && m_getterMethod.IsVirtual && m_setterMethod == null) |
There was a problem hiding this comment.
nit: as mentioned earlier, is null and is not null is preferred over == null and != null since it will prevent a call to the == or != operator if that is overridden. In this case, it is just more obvious to understand intent when using RuntimeMethodInfo doesn't overload those operators so it doesn't matter butis.
There was a problem hiding this comment.
RuntimeMethodInfo doesn't overload those operators so it doesn't matter
MethodInfo does overload those operators. MethodInfo operators are going to be selected to compare RuntimeMethodInfo quick test
There was a problem hiding this comment.
Oops thanks; updated comment
| out _, out _, out _, | ||
| out m_getterMethod, out m_setterMethod, out m_otherMethod, | ||
| out isPrivate, out m_bindingFlags); | ||
|
|
||
| // lookup getter/setter when getter and setter are inherited from base class but just a setter/getter is overridden on a sub type |
There was a problem hiding this comment.
nit: start a comment with upper case letter and end with a period.
Fixes #110412