Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

realpath in c# #45637

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

realpath in c# #45637

wants to merge 3 commits into from
+35 −90

Conversation

kasperk81
Copy link
Contributor

.net framework is windows only and current netcore has ResolveLinkTarget

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 27, 2024
@KalleOlaviNiemitalo
Copy link
Contributor

In the following scenario, I think Interop.Unix.realpath(dotnetExeFromPath) would return "/stash/homes/myself/bin/dotnet", but info.LinkTarget would be null:

  • PATH includes /home/myself/bin
  • /home is a symbolic link to /stash/homes
  • /stash/homes/myself/bin/dotnet is a regular file

Does that difference cause any problem?

@build-analysis build-analysis bot mentioned this pull request Dec 27, 2024
Open
@kasperk81
Copy link
Contributor Author

it now walks the parent up to the first link, combine with returnFinalTarget: true of ResolveLinkTarget

This was referenced Dec 27, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperk81 @KalleOlaviNiemitalo