Style ToolTip to make it dark enough in Dark mode

[willibrandon]

Fixes #11954

Proposed changes

• Style the ToolTip using DarkMode_Explorer theme and round the corners with a small radius.

Customer Impact

• Fixes an issue with ToolTip not being dark enough in Dark mode.

Regression?

• No

Risk

• I believe risk is low.

Screenshots

Before

After

Test methodology

• Run unit and integration tests.
• Manually tested.

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 4.39560% with 87 lines in your changes missing coverage. Please review.

Project coverage is 75.70903%. Comparing base (c9aa1c9) to head (625896f).
Report is 32 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #12420         +/-   ##
===================================================
+ Coverage   75.64273%   75.70903%   +0.06629%     
===================================================
  Files           3147        3153          +6     
  Lines         635806      635800          -6     
  Branches       47012       46982         -30     
===================================================
+ Hits          480941      481358        +417     
+ Misses        151423      151004        -419     
+ Partials        3442        3438          -4     

Flag	Coverage Δ
Debug	75.70903% <4.39560%> (+0.06629%)	⬆️
integration	18.26839% <0.00000%> (+0.02931%)	⬆️
production	49.27218% <0.00000%> (+0.09778%)	⬆️
test	97.04151% <11.11111%> (+0.01066%)	⬆️
unit	46.24786% <0.00000%> (+0.11792%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[lonitra]

Overall changes LGTM, @KlausLoeffelmann what do you think of the changes here?

[memoarfaa]

This will disable round corners see
#11907 (comment)_

also treeview,listview,tabs and some other controls has internal tooltips need to be darked.

[willibrandon]

Marking this PR as a draft as @memoarfaa has pointed out that it could be improved. I need to take a look at the DarkMode_Explorer theme and how it's currently used to style ComboBox and ListView in Dark mode.

@memoarfaa - Have you done work in this area already?

[willibrandon]

@memoarfaa - Here's an example with your suggestions applied.

DarkMode_Explorer with rounded corners.

[willibrandon]

DarkMode_Explorer with small rounded corners.

[willibrandon]

@memoarfaa Thank you for the heads up. I understand there are some other internal tooltips that will need to be darkened and I plan to help out with those when I can. I've implemented your suggestions here and have rounded the corners with a small radius.

[willibrandon]

DarkMode_Explorer with a balloon window.

[willibrandon]

ListView ToolTip

Before:

After:

[willibrandon]

TreeView ToolTip

Before:

After:

[willibrandon]

TabControl ToolTip

Before:

After:

[willibrandon]

@memoarfaa Are you aware of any other tooltips that need to be darkened?
I believe I have exhausted the list of relevant *GETTOOLTIPS messages I see in the docs.

[willibrandon]

The tooltips have been styled to be dark when dark mode is enabled, including the balloons, and the corners have been rounded for Windows 11 or greater. I need some guidance on how to unit test and verify the theme being used by the tooltip when the system is in dark mode. If someone could give me a nudge for the test, I would greatly appreciate it.

This pull request is ready for review.

[toehead2001]

Even when not in Dark Mode, I believe it would be advantageous to set the corners to RoundSmall.
It better matches the Windows 11 styling, and just looks better (in my opinion).

Default corners

RoundSmall corners