Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit test for DataGridViewAddColumnDialog #12662

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Liv-Goh
Copy link
Contributor

@Liv-Goh Liv-Goh commented Dec 20, 2024

Related #10773

Proposed changes

  1. Add unit test DataGridViewAddColumnDialogTests.cs for public properties and method of the DataGridViewAddColumnDialog.
  2. Enable nullability in DataGridViewAddColumnDialogTests.cs.
Microsoft Reviewers: Open in CodeFlow

@Liv-Goh Liv-Goh requested a review from a team as a code owner December 20, 2024 01:51
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.07613%. Comparing base (230d349) to head (750a6ce).
Report is 37 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12662         +/-   ##
===================================================
+ Coverage   75.91962%   76.07613%   +0.15651%     
===================================================
  Files           3164        3165          +1     
  Lines         636813      639374       +2561     
  Branches       47008       47186        +178     
===================================================
+ Hits          483466      486411       +2945     
+ Misses        149884      149448        -436     
- Partials        3463        3515         +52     
Flag Coverage Δ
Debug 76.07613% <88.05970%> (+0.15651%) ⬆️
integration 18.14769% <ø> (-0.02873%) ⬇️
production 49.88527% <ø> (+0.26805%) ⬆️
test 97.02746% <88.05970%> (-0.02526%) ⬇️
unit 47.10722% <ø> (+0.27244%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Dec 20, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, all LGTM!

@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Dec 20, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 23, 2024
@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Dec 23, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants