-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to main branch to address #12042 #12674
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12674 +/- ##
===================================================
- Coverage 76.03358% 76.02900% -0.00459%
===================================================
Files 3180 3181 +1
Lines 639670 639698 +28
Branches 47215 47217 +2
===================================================
- Hits 486364 486356 -8
- Misses 149791 149822 +31
- Partials 3515 3520 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi there. I'm not sure what to do with the codecov report. For perspective, I have been a developer for 20 odd years, but haven't done changes through github for MS before. Cheers. |
@dotnet-policy-service agree |
This is my first PR for MS. I didn't really understand what was happening with the accessibility testing software. |
Fixes #12042 - TreeNode and ListItem not displaying in dark mode during editing, even though application is set to be in dark mode.
Proposed changes
If the application is in dark mode, capture the parent's windows message to identify the start of editing, and change the colour of the brush to match the parent's window color.
Customer Impact
Correction of incorrect color selection.
Regression?
Risk
I tried to limit the impact of the change to only occurring when the application is in dark mode. I'm not sure of the impact, if any, on custom ListView subitems, or custom-drawn TreeNodes.
Screenshots
Before
After
Test methodology
I used the test application provided to highlight the bug in the ticket to test the new behaviour.
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow