-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StyleCleanUp] Address IDE Warnings Part 1 #10168
Open
harshit7962
wants to merge
1
commit into
dotnet:main
Choose a base branch
from
harshit7962:editorconfigCleanup11
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
December 12, 2024 07:09
dotnet-policy-service
bot
added
the
PR
metadata: Label to tag PRs, to facilitate with triage
label
Dec 12, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
...t.Wpf/src/UIAutomation/UIAutomationClient/MS/Internal/Automation/HwndProxyElementProvider.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Media/Animation/Storyboard.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationUI/MS/Internal/Documents/Application/DocumentStream.cs
Show resolved
Hide resolved
...icrosoft.DotNet.Wpf/src/PresentationUI/MS/Internal/Documents/Application/RightsController.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationUI/MS/Internal/Documents/RightsManagementProvider.cs
Show resolved
Hide resolved
...Microsoft.DotNet.Wpf/src/PresentationUI/MS/Internal/Documents/Application/DocumentManager.cs
Show resolved
Hide resolved
himgoyalmicro
approved these changes
Dec 16, 2024
harshit7962
added
Included in test pass
Status:Committed
and removed
Queue for test pass
Status:Proposed
labels
Dec 17, 2024
Will be taking care of whitespace changes in a separate PR. Resolving the relevant nits for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Included in test pass
PR
metadata: Label to tag PRs, to facilitate with triage
Status:Committed
Status:Cut
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work is a part of our initiative to set code-style guidelines, align WPF and WinForms, and ensure PR standards with respect to styles. This in turn will help us in better maintainability and readability of the repo overall. The changes follow up from the PR #10080 and references to the issue #10017.
This PR addresses IDE0017: Use object initializers.
Link to the issue: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0017
Customer Impact
None
Regression
None
Testing
Local Build Pass
Will be taken in test pass
Microsoft Reviewers: Open in CodeFlow