Fix up many linting issues #4652
Conversation
eq does object identity checking, while equal does recursive value checking.
github-actions
bot
added
rust
client
clients/lsp-camel.el
Outdated
| :group 'lsp-camel | ||
| :type 'file | ||
| :type 'directory |
There was a problem hiding this comment.
this should be file instead of directory, no?
There was a problem hiding this comment.
Ah, got confused from the comment above and seeing the word dir too many times. Definitely should be file
| :type '(choice (const "off") | ||
| (const "messages") | ||
| (const "verbose") | ||
| ) |
There was a problem hiding this comment.
Can you move ) to the previous line? Thanks!
| (const "retext-english") | ||
| (const "remark-parse"))) | ||
| (const "remark-parse")) |
There was a problem hiding this comment.
Can you fix the style to:
:type '(choice (const "retext-english")
(const "remark-parse")))
(const "remark-parse"))| (const "Lua 5.3") | ||
| (const "Lua 5.4") | ||
| (const "LuaJIT") | ||
| ) |
There was a problem hiding this comment.
Can you fix the style to:
:type '(choice (const "Lua 5.1")
(const "Lua 5.2")
(const "Lua 5.3")
(const "Lua 5.4")
(const "LuaJIT"))| (const "info") | ||
| (const "hint") | ||
| (const "none") | ||
| )) |
There was a problem hiding this comment.
Can you fix the style to:
'(choice (const "error")
(const "warning")
(const "info")
(const "hint")
(const "none")))And add a simple docstring to the variable? :)
| (cons 'name string) | ||
| (cons 'description string) | ||
| (cons 'url string) | ||
| (cons 'fileMatch (repeat string)))) |
There was a problem hiding this comment.
Can you add documentation to this variable? The indentation seems a bit off here. 🤔
|
Thank you! |
|
Sorry about not getting back to this in a timely manner! End of year stuff. Thanks for getting this over the finish line |
Most of these are fixing up issues with the type declarations in customization variables. These all were highlighted by
eask.There's also a handful of other fixups:
(eq foo [])with(equal foo [])in a couple of spots (first one does an identity check so would never pass)