-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for vertical screens #584
base: main
Are you sure you want to change the base?
Conversation
I set the threshold to 1400px so people who have some resolution lower than 1920 don't have the short bar unless necessary. The overview is still to wide but I dont really wanna fix it rn. The rest are improvements nonetheless and there should be no changes for vertical screens so this can be merged if there are no issues. |
Good idea, but I think it could be done better
|
Oh I didn't even think of that. Guess that's a better solution. Using the font size and the width of the elements to check whether that's wider than the screen could be possible. |
short
mode for the bar. Only used if the screen has a width smaller than a certain value and currentShellMode isnormal
.That fixes the logout menu not being in the center of the screen and the bar being cursed on vertical screens.
Issues:
short
mode was chosen arbitrarily (currently 1800, cause that is smaller than 1920). It works for vertical 1920x1080 screens but might not for other sizes.For horizontal screens nothing should have changed.
Any feedback and ideas are appreciated :)