Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcproxy: use metadata instead of context withvalue in with client auth token #19033

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krijohs
Copy link

@krijohs krijohs commented Dec 9, 2024

Change to use metadata instead of context.WithValue to ensure each proxy watcher client has a new stream created with its token.
Previously context.WithValue resulted in streamKeyFromCtx returning an empty string in the clientv3 watcher, causing stream reuse.
When new clients connected to proxy after the token expired (token for the initial client which connected) the reused stream's context would still contain the expired token. This caused auth failures when isWatchPermitted on cluster checked the stream's context resulting in hanging proxy watcher clients.

Issue can be reproduced by setting a low --auth-token-ttl on cluster and connect 1 client first to proxy and then connect a second one after token expired.

Also adds increase of watchersCoalescing metric when watchers have been coalesced.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krijohs
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @krijohs. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@krijohs
Copy link
Author

krijohs commented Dec 19, 2024

Added test case which reproduces the issue, with included change it passes but without fails

@krijohs krijohs force-pushed the grpcproxy-client-auth-token branch from 3d3b143 to 8d9e89f Compare December 19, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants