-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still return continuous WAL entries when running into ErrSliceOutOfRange #19095
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Benjamin Wang <[email protected]>
Confirmed that this PR can fix the error in #19038 (comment). @siyuanfoundation please let me know if you can still reproduce it in your environment. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19095 +/- ##
==========================================
- Coverage 68.77% 68.71% -0.06%
==========================================
Files 420 420
Lines 35642 35642
==========================================
- Hits 24513 24492 -21
- Misses 9703 9719 +16
- Partials 1426 1431 +5 Continue to review full report in Codecov by Sentry.
|
Thanks for the confirmation. Can we get this merged firstly? PTAL cc @serathius |
Please read #19038 (comment) and #19038 (comment)
cc @serathius @siyuanfoundation
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.