Avoid augmenting subarrays post-ES2016

feross · Feb 4, 2024 · b445655 · b445655
1 parent 54885d4
commit b445655
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -1117,6 +1117,8 @@ function utf16leSlice (buf, start, end) {
   return res
 }
 
+let subarrayCallsChild = false;
+
 Buffer.prototype.slice = function slice (start, end) {
   const len = this.length
   start = ~~start
@@ -1139,8 +1141,11 @@ Buffer.prototype.slice = function slice (start, end) {
   if (end < start) end = start
 
   const newBuf = this.subarray(start, end)
-  // Return an augmented `Uint8Array` instance
-  Object.setPrototypeOf(newBuf, Buffer.prototype)
+
+  if (!subarrayCallsChild) {
+    // Return an augmented `Uint8Array` instance
+    Object.setPrototypeOf(newBuf, Buffer.prototype)
+  }
 
   return newBuf
 }
@@ -2152,3 +2157,7 @@ function defineBigIntMethod (fn) {
 function BufferBigIntNotDefined () {
   throw new Error('BigInt not supported')
 }
+
+if (Buffer.TYPED_ARRAY_SUPPORT) {
+  subarrayCallsChild = createBuffer(1).subarray(0, 1) instanceof Buffer
+}