Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flexbox example the odin project #555

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Sembauke
Copy link
Member

Checklist:

Closes #XXXXX

Copy link

socket-security bot commented Dec 13, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@codesandbox/sandpack-react 2.10.0 eval, network, filesystem +47 80 MB danilowoz

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Protestware/Troll package es5-ext 0.10.62
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale

Next steps

What is protestware and troll packages?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@Sembauke
Copy link
Member Author

I am not sure why the linter is so whiney.

@Sembauke Sembauke requested a review from naomi-lgbt December 13, 2023 19:45
@naomi-lgbt
Copy link
Member

I'll take a peek.

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sembauke,

Some notes here:

  • First, this needs to be wrapped in an express server so that PM2 can serve it correctly (and the tests expect that as well).
  • Second, I don't believe our pipeline allows for a build step - we'd need to fetch React from a CDN and serve the index.html file through Express.

You can refer to the apps/markdown-previewer project to see how this is done.

@Sembauke Sembauke force-pushed the feat/top-flex-box-example branch from 4938a25 to efdf7eb Compare December 14, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants