Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc interceptors #938

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add grpc interceptors #938

wants to merge 10 commits into from

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Dec 27, 2024

Resolves #240

Sample error logged to Sentry:

CleanShot 2024-12-27 at 09 52 53

Possible improvements / todos:

  • Create docs in sentry and sentry-docs
  • The options is a simple struct (as in other integrations). Could implement Functional Options Pattern for these.
  • More tests and examples?

@ribice ribice requested a review from cleptric December 27, 2024 08:55
@ribice ribice changed the title grpc interceptors Add grpc interceptors Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 84.29119% with 41 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (109fca1) to head (dda5723).

Files with missing lines Patch % Lines
grpc/server.go 80.11% 28 Missing and 7 partials ⚠️
grpc/client.go 92.94% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   83.64%   83.67%   +0.03%     
==========================================
  Files          49       52       +3     
  Lines        5129     5410     +281     
==========================================
+ Hits         4290     4527     +237     
- Misses        682      718      +36     
- Partials      157      165       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC interceptors
2 participants