Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browserHistory): Remove from transactionEvents #82630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

ref(browserHistory): Remove from transactionEvents #82630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions static/app/views/performance/transactionSummary/transactionEvents/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {t} from 'sentry/locale';
import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {trackAnalytics} from 'sentry/utils/analytics';
import {browserHistory} from 'sentry/utils/browserHistory';
import DiscoverQuery from 'sentry/utils/discover/discoverQuery';
import EventView from 'sentry/utils/discover/eventView';
import {
Expand All @@ -18,6 +17,7 @@ import {WebVital} from 'sentry/utils/fields';
import {removeHistogramQueryStrings} from 'sentry/utils/performance/histogram';
import {decodeScalar} from 'sentry/utils/queryString';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import {useNavigate} from 'sentry/utils/useNavigate';
import withOrganization from 'sentry/utils/withOrganization';
import withProjects from 'sentry/utils/withProjects';

Expand Down Expand Up @@ -75,6 +75,7 @@ function EventsContentWrapper(props: ChildProps) {
projectId,
projects,
} = props;
const navigate = useNavigate();
const eventsDisplayFilterName = decodeEventsDisplayFilterFromLocation(location);
const spanOperationBreakdownFilter = decodeFilterFromLocation(location);
const webVital = getWebVital(location);
Expand Down Expand Up @@ -126,7 +127,7 @@ function EventsContentWrapper(props: ChildProps) {
if (newFilter === SpanOperationBreakdownFilter.NONE) {
delete nextQuery.breakdown;
}
browserHistory.push({
navigate({
pathname: location.pathname,
query: nextQuery,
});
Expand All @@ -150,7 +151,7 @@ function EventsContentWrapper(props: ChildProps) {
delete nextQuery.showTransaction;
}

browserHistory.push({
navigate({
pathname: location.pathname,
query: nextQuery,
});
Expand Down
Loading