-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify use of labels and groups together #35715
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Nuru Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you @Nuru for digging into this and improving the docs.
While we are in a repo freeze right now. I think this would be good to merge once the freeze is lifted.
Why:
What's being changed (if available, include any code snippets, screenshots, or gifs):
As correctly explained under Using labels and groups to route jobs, when you combine groups and labels, the runner must meet both requirements to be eligible to run the job. Therefore, a statement like "GitHub looks for a runner that matches the job's runs-on labels and/or groups" is confusing and wrong. The runner must match the job's labels and groups and will not be selected if it only matches the job's labels or groups but not both. So all the "and/or" instances have been changed to "and".
Reference to ARC at the top of the article has been changed to a reference to Runner Scale Sets for accuracy. The Note has been upgraded to Important because the entire article does not apply if you are using Runner Scale Sets.
Check off the following: