Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of labels and groups together #35715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Nuru
Copy link

@Nuru Nuru commented Dec 19, 2024

Why:

What's being changed (if available, include any code snippets, screenshots, or gifs):

As correctly explained under Using labels and groups to route jobs, when you combine groups and labels, the runner must meet both requirements to be eligible to run the job. Therefore, a statement like "GitHub looks for a runner that matches the job's runs-on labels and/or groups" is confusing and wrong. The runner must match the job's labels and groups and will not be selected if it only matches the job's labels or groups but not both. So all the "and/or" instances have been changed to "and".

Reference to ARC at the top of the article has been changed to a reference to Runner Scale Sets for accuracy. The Note has been upgraded to Important because the entire article does not apply if you are using Runner Scale Sets.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

Copy link

welcome bot commented Dec 19, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 19, 2024
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners/using-self-hosted-runners-in-a-workflow.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 19, 2024
@nguyenalex836
Copy link
Contributor

@Nuru Thanks so much for opening a PR! I'll get this triaged for review ✨

Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you @Nuru for digging into this and improving the docs.

While we are in a repo freeze right now. I think this would be good to merge once the freeze is lifted.

cc @nguyenalex836

@nguyenalex836 nguyenalex836 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants