Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve topic "ECMAScript" #3935

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Improve topic "ECMAScript" #3935

merged 5 commits into from
Sep 28, 2023

Conversation

shaedrich
Copy link
Contributor

@shaedrich shaedrich commented Sep 21, 2023

  • Fix short_description
  • Add information to description
  • Add related
  • Add released

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

ECMAScript has different implementations and such

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

- Fix short_description
- Add information to description
- Add related
- Add released
@shaedrich shaedrich requested a review from a team as a code owner September 21, 2023 06:23
@shaedrich
Copy link
Contributor Author

shaedrich commented Sep 21, 2023

Or is "ecma-262" more of an alias?

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! 🎉

@zkoppert zkoppert added this pull request to the merge queue Sep 28, 2023
Merged via the queue into github:main with commit f4b38a0 Sep 28, 2023
5 checks passed
@shaedrich shaedrich deleted the ecmascript branch September 29, 2023 01:57
@shaedrich
Copy link
Contributor Author

One does what one can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants