Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploratory test cases for rails_view_render_literal #221

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Exploratory test cases for rails_view_render_literal #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c83f142
Exploratory test cases for rails_view_render_literal
bensheldon Dec 16, 2024
b7e40e4
Update render_literal_helpers.rb to allow for inline block content
bensheldon Dec 16, 2024
11d5766
Update render_literal_helpers.rb
bensheldon Dec 16, 2024
8c91e22
Update render_literal_helpers.rb
bensheldon Dec 16, 2024
ec12a4c
Update render_literal_helpers.rb
bensheldon Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/rubocop/cop/github/render_literal_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ module RenderLiteralHelpers
PATTERN

def_node_matcher :render_view_component_instance_with_content?, <<-PATTERN
(send nil? {:render :render_to_string} (send (send _ :new ...) `:with_content ...))
(send nil? {:render :render_to_string} (send (send _ :new ...) :with_content ...))
PATTERN

def_node_matcher :render_view_component_instance_with_inline_block?, <<-PATTERN
(block (send nil? {:render :render_to_string} (send _ :new ...)) ...)
PATTERN

def_node_matcher :render_view_component_collection?, <<-PATTERN
Expand All @@ -47,6 +51,7 @@ def hash_with_literal_keys?(hash)

def render_view_component?(node)
render_view_component_instance_with_content?(node) ||
render_view_component_instance_with_inline_block?(node) ||
render_view_component_instance?(node) ||
render_view_component_collection?(node)
end
Expand Down
24 changes: 24 additions & 0 deletions test/test_rails_view_render_literal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,30 @@ def test_render_component_instance_block_no_offense
assert_equal 0, offenses.count
end

def test_render_component_instance_inline_block_no_offense
offenses = erb_investigate cop, <<-ERB, "app/views/foo/index.html.erb"
<%= render Module::MyClass.new(title: "foo", bar: "baz") { "Content" } %>
ERB

assert_equal 0, offenses.count
end

def test_render_component_instance_data_object_no_offense
offenses = erb_investigate cop, <<-ERB, "app/views/foo/index.html.erb"
<%= render Module::MyClass.new(title: "foo", bar: "baz", data: { foo: "bar" }) %>
ERB

assert_equal 0, offenses.count
end

def test_render_component_instance_data_object_no_offense
offenses = erb_investigate cop, <<-ERB, "app/views/foo/index.html.erb"
<%= render Module::MyClass.new(title: "foo", bar: "baz", data: { foo: "bar" }) %>
ERB

assert_equal 0, offenses.count
end

def test_render_component_collection_no_offense
offenses = erb_investigate cop, <<-ERB, "app/views/foo/index.html.erb"
<%= render MyClass.with_collection(title: "foo", bar: "baz") %>
Expand Down
Loading