Updated according to lint rules #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting failed in deploymentConfig.js due to the static fields. Eslint supports this from ecmaVersion 13.
The full test suite failed because it tried to lint the tests, while the running linter did not do the same. Enabling linting gave errors due to jest having undef stuff, but overriding these files for jest env keeps the linting without these errors.
Removed to stop having eslint errors.
Updated with `npx standard --fix`. Skipping environments.js and environments.test.js as they had a lot of errors, handling those in a separate commit.
Updated with `npx standard --fix`.
This was done manually as no autofix was available.
|
@decyjphr I see that the eslint config is changing from extending "standard" to extending "eslint:recommended" in #664. Would it be interesting if I made a new version of this, but using the new Eslint rules? I am hoping the repo can reach a the point where there are no lint errors, thus allowing enforcing linting on PRs, and would be happy to contribute towards that goal if it aligns with your goals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes to
.eslintrc.jsonand then updates the remaining code to follow the current linting rules.These are the changes that are not pure updates to follow linting standards:
parserOptions.ecmaVersionfrom 12 to 13. This is due to code in this project that fails the lint test in ecma 12.test/**/*.jsto overriding theenvtojestfor these files. By doing this we can get linter hints in the editor without the linter failing.All other changes are either done by running
npx standard --fix, or some manual renaming of variables from snake_case to camelCase, again to adhere to project standards.Feel free to discard this PR, but I am hoping it is a useful improvement to the codebase.