-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Private README.md for organization #32872
base: main
Are you sure you want to change the base?
Conversation
54593db
to
55af509
Compare
Could you add some tests in If I understand correctly: view as public: private repositories won't be listed. |
In this design So viewing as public does not mean that a member user will not see private repos listed if he/she already has permission. |
Maybe GitHub also changed their behavior: While I still think it needs to add some tests in |
I'm working on it. Trying to get familiar with the integration tests. |
4347353
to
48b4be2
Compare
@@ -44,6 +44,8 @@ | |||
<div class="inline required field {{if .Err_RepoName}}error{{end}}"> | |||
<label for="repo_name">{{ctx.Locale.Tr "repo.repo_name"}}</label> | |||
<input id="repo_name" name="repo_name" value="{{.repo_name}}" autofocus required maxlength="100"> | |||
<span id="repo_name_public_profile_hint" style="display:none" class="help">{{ctx.Locale.Tr "repo.repo_name_public_profile_hint"}}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use tw-hidden
class rather than style="display:none"
.
Implemented #29503
Changes:
.profile
repository name forREADME.md
, adding the private one, I rename the contexts withPublic
andPrivate
inside them.view_as
query parameter. Still, the existing query scheme is quite limited due to the integration with the search form and the repository paginator, so my workaround is to forcefully bring augmented query strings of member/public to the tmpl file.Things lack and need further guidance:
.profile
the make repository private checkbox should be disabled and stay unchecked, whereas.profile-private
, the checkbox should be disabled and force checked.Screenshots
Demo:
Need help: