-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Migrate Prometheus Middleware to Contrib #1032
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@gaby is it ready for review ? |
This weekend :-) |
Hello! Is there any update on a timeframe to merging this? |
@Fesaa Hopefully soon, I did some changes upstream that need to be merged here. I also wanted to simplify the middleware a bit. The other thing I wanted to probably do is add an option for exporting Host metrics using this https://github.com/prometheus/node_exporter |
@Fesaa Now that I thinj about maybe initial release is as it is right now. For next release I can do changes/features. That way we can get this released soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @gaby ready for merge ?
With the recent changes in ansrivas/fiberprometheus#221 I have to migrate those to this PR and it should be ready to merged. For |
TODO:
GoRuntime
collector.Original middleware created and contributed by https://github.com/ansrivas/fiberprometheus