-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SliceTricks: use builtin clear #24
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: d14e876) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/wiki/+/609517. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609517. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/609517. |
Message from Ian Lance Taylor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609517. |
After filtering without allocating, it's recommended to loop over the underlying slice `a` and setting all unneeded values to `nil` manually if they're to be gc'ed. Instead, one might simply use the builtin `clear` on the sub-slice starting at the end of `b`.
This PR (HEAD: 2c8f01e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/wiki/+/609517. Important tips:
|
Message from Niklas Hennings: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609517. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/609517. |
@ianlancetaylor Pinging you, if this will be merged soon? |
After filtering without allocating, it's recommended to loop over the underlying slice
a
and setting all unneeded values tonil
manually if they're to be gc'ed.Instead, one might simply use the builtin
clear
on the sub-slice starting at the end ofb
.