GraphiQL v4 #3685
GraphiQL v4 #3685
Conversation
🦋 Changeset detectedLatest commit: 068e23c The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are not available as canary, since there are no linked |
* new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * Update .changeset/thirty-spoons-call.md * fix cypress * this fix locally --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3685 +/- ##
==========================================
- Coverage 65.32% 65.30% -0.03%
==========================================
Files 122 121 -1
Lines 7003 7006 +3
Branches 2260 2263 +3
==========================================
Hits 4575 4575
- Misses 2411 2414 +3
Partials 17 17
|
* new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>
* new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>
… remove development code from cdn bundle (#3683) * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * upd graphql * aa * yarn.lock * fix tests
…ized branches to deploy
* remove `disableTabs` option * format
…over `window.navigator` (#3692)
* test umd build only on ci, locally test cdn.ts * Update custom-words.txt
* aa * fix netlify * fix * fix fails on ci
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* improve explorer styles * aa
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* add vite replace html plugin for graphiql plugin explorer * fix build
|
@dimaMachina what is the rationale behind removing the |
| * @param query The current value of the query editor. | ||
| * @returns {string} The formatted query | ||
| */ | ||
| onPrettifyQuery?: (query: string) => string; |
There was a problem hiding this comment.
@dimaMachina along the lines of our previous discussion, i think we should discontinue exposing handlers and state via props, and expose them via hooks instead, then people can provide formatters as plugins. in this case it's simply a callback and no state, so it doesn't impact the controlled vs uncontrolled scenario, but for something like this that is more likely to be used by plugins, we should expose that instead, and provider a prettier plugin
There was a problem hiding this comment.
we already expose the use editor hooks and users can use the refs, so a compositional @graphiql/react experience already exists (as of course GraphiQL has been!), so we should just provide a simple example in examples of a custom editor?
| * @param query The current value of the query editor. | ||
| * @returns {string} The formatted query | ||
| */ | ||
| onPrettifyQuery?: (query: string) => string; |
There was a problem hiding this comment.
| onPrettifyQuery?: (query: string) => string; | |
| onPrettifyQuery?: async (query: string) => string; |
and the required changes as such, as prettier.format returns a promise, for example
No description provided.