Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clear the template cache after uninstalling the theme #7174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 27, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

卸载主题之后清理模板缓存

此问题是 #2970 的遗留问题

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Dec 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Dec 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG December 27, 2024 04:04
Copy link

f2c-ci-robot bot commented Dec 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.20%. Comparing base (eff73dc) to head (639bfed).
Report is 82 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7174      +/-   ##
============================================
+ Coverage     56.99%   57.20%   +0.20%     
- Complexity     3999     4047      +48     
============================================
  Files           714      719       +5     
  Lines         24110    24349     +239     
  Branches       1585     1598      +13     
============================================
+ Hits          13742    13929     +187     
- Misses         9756     9803      +47     
- Partials        612      617       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant