Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: international #335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pedrocarlo
Copy link
Contributor

Description

Added an I18n package using next-international. I personally like next-international, as it is easy to setup and quite simple to get going. For this package, I mirrored closely how the @repo/auth was built with clerk. I created a middleware, server, and client file to export the necessary functions from next-international, and created a sample folder of with a basic en localization to exemplify how to get started.

Related Issues

#297

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if necessary.
  • I have added tests that prove my fix is effective or my feature works.
  • New and existing tests pass locally with my changes.

Additional Notes

  • Edited the tsconfig for @repo/i18n to "moduleResolution": "bundler" and "module": "ESNext" to support relative imports.
  • Added necessary peerDependencies to circumvent some type errors

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-forge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:36pm
next-forge-app ❌ Failed (Inspect) Dec 9, 2024 11:36pm

Copy link

vercel bot commented Dec 9, 2024

@pedrocarlo is attempting to deploy a commit to the Hayden Bleasel Team on Vercel.

A member of the Team first needs to authorize it.

@pedrocarlo
Copy link
Contributor Author

I have not updated the docs, as I am not quite familiar with writing docs. I would appreciate some help on that. Thanks!

@yamz8
Copy link
Contributor

yamz8 commented Dec 22, 2024

Any plans to merge it @haydenbleasel ?

@PierrickLozach
Copy link

I think you need to change the package.json name to "@repo/i18n" otherwise this breaks pnpm dev

@PierrickLozach
Copy link

Also, I think it would help to have an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants