fix(a19): respecting default standalone flag since angular 19

[re-alam]

Added standalone false as default for mock-render and updated isStandalone method to handle angular 19+ default standalone behavior for components.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cad1d0e) to head (a310e94).
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master    #10583   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines         4946      4950    +4     
  Branches      1148      1149    +1     
=========================================
+ Hits          4946      4950    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jensweigele]

I think you need to adapt the unit-tests to get green-light from CI (and approval from @satanTime )

[satanTime]

Hi @re-alam, thanks for the fix.

Could stash all commits into one?
Also, please change the message of the commit to:

fix(a19): respecting default standalone flag since angular 19

Thank you in advance.

[satanTime]

Hi @re-alam, could you sign your commit?

the easiest way is SSH signing: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[re-alam]

@satanTime Thank you for approving the change. My commit is now signed. Please feel free to merge when you're able.

[satanTime]

It's an internal function and it shouldn't be a part of public interface.

I think the test should be done in a different way. There are some examples in tests folder which verify different behaviors of different angular versions.

[re-alam]

@satanTime Thank you for your feedback. I've looked into the tests folder but couldn't find any tests that specifically cover the feature or logic related to Angular version checks. I only found some tests that skip execution based on the Angular version, like this:

if (Number.parseInt(VERSION.major, 10) < 14) {
  it('needs >=a14', () => {
    expect(true).toBeTruthy();
  });
  return;
}

However, I need to ensure code coverage for the Angular 19 version check within the isStandalone function.

I attempted to mock the VERSION object using spyOnProperty, but this wasn't possible as the VERSION object from @angular/core isn't configurable.

Given that isStandalone is an internal function, what do you think about moving the test file to the common folder? Please let me know if there are any other approaches I should consider.

[florestankorp]

Shouldn't there be an addition to the 'e2e' folder?

[endlacer]

this should be merged ASAP.
having a testing library block the upgrade of the app to angular 19 is quite the bummer

[GipHub123]

@endlacer Some people don’t seem to understand that most libraries are maintained on a pro bono basis, without any financial compensation 😠 These developers generously dedicate their free time to create and maintain fantastic development tools that benefit us all.

this has to be merged ASAP. having a testing library block the upgrade of the app to angular 19 is highly unacceptable!

[florestankorp]

this has to be merged ASAP. having a testing library block the upgrade of the app to angular 19 is highly unacceptable!

@endlacer I understand your frustration, but this doesn't have to be blocking: take this fix, build it and temporarily include it in your bundle to import from there. That's what I'm doing for now and it works. DM me if you have questions or need any help with this.

[TomLBarden]

@endlacer I understand your frustration, but this doesn't have to be blocking: take this fix, build it and temporarily include it in your bundle to import from there. That's what I'm doing for now and it works. DM me if you have questions or need any help with this.

A bit of guidance on this would be hugely appreciated!

[endlacer]

this has to be merged ASAP. having a testing library block the upgrade of the app to angular 19 is highly unacceptable!

@endlacer I understand your frustration, but this doesn't have to be blocking: take this fix, build it and temporarily include it in your bundle to import from there. That's what I'm doing for now and it works. DM me if you have questions or need any help with this.

sorry for being too harsh, but we got 4 applications and 2 libraries that all are now blocked bc of something that
a. seems minor
b. already a PR exists to fix it

did not mean any offense!

[florestankorp]

@endlacer I understand your frustration, but this doesn't have to be blocking: take this fix, build it and temporarily include it in your bundle to import from there. That's what I'm doing for now and it works. DM me if you have questions or need any help with this.

A bit of guidance on this would be hugely appreciated!

@TomLBarden here you go:

1. Clone 'ng-mocks'
2. Install the dependencies with npm install
3. Apply the changes suggested in this PR
4. Build the lib by running: npm run build:all
5. Copy the folder ng-mocks from dist into your project
6. Update the imports in your project to point at the newly imported version of 'ng-mocks'
7. Optional: Disable ESLint for ng-mocks by ignoring the folder:

// eslint.config.js
export default [
    {
        ignores: ["**/ng-mocks/**"]
    }
];

Your tests should be running now with Angular v19 😎

[TomLBarden]

@florestankorp Thank you!

I wanted to let you know that I did a build based on this PR, and it does not seem to be enough to solve all the issue caused by components being standalone by default in Angular 19.

It works for components directly inside the application, but not for non-standalone components from libraries. I get errors like this one:

@ct-serensia I'm seeing this issue too, did you happen to find a solution for it? I'll continue to investigate this myself, too.

[endlacer]

My workaround for now is to install back Angular 18 to run unit tests, while everything else (serve, build...) uses Angular 19.

this might work local, but not in a CI pipeline

[TomLBarden]

My workaround for now is to install back Angular 18 to run unit tests, while everything else (serve, build...) uses Angular 19.

@ct-serensia That's a shame, thanks for the reply though. Looking like I might have to delay this upgrade for now. Unfortunately for us we can't accept the risk of testing against a different version of Angular than we'd be shipping with.

[endlacer]

ct-serensia i dont even this this would work. the angular 19 migration removes standalone: true flags from the component. when you then run tests with angular 18, the tests would think that this component is standalone-false, which it is not

[szigetib95]

I don't see any update on this for last 2 weeks as it's being worked on, it would be very helpful to get this problem resolved, as it is stopping the complete Nx migration for all our repos.
Thanks!

[florianjung79]

For the time being, we continue to declare the standalone components with standalone: true. The tests then run as before and as soon as ng-mocks offers a corresponding fix, the global removal of the declaration is a matter of search and replace.

[szigetib95]

For the time being, we continue to declare the standalone components with standalone: true. The tests then run as before and as soon as ng-mocks offers a corresponding fix, the global removal of the declaration is a matter of search and replace.

'The global removal of the declaration is a matter of search and replace' - In case your components are standalone, but I need the flag, since its standalone: false.

[florestankorp]

standalone:

@florianjung79 Do you mean you set your MockRender / MockBuilder to standalone: true? Or your actual components? Can you provide a code snippet?

[florianjung79]

@florianjung79 Do you mean you set your MockRender / MockBuilder to standalone: true? Or your actual components? Can you provide a code snippet?

The actual components.